Skip to content

8365976: G1: Full gc should mark nmethods on stack #26899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

8365976: G1: Full gc should mark nmethods on stack #26899

wants to merge 1 commit into from

Conversation

tschatzl
Copy link
Contributor

@tschatzl tschatzl commented Aug 22, 2025 •
edited by openjdk bot
Loading

Hi all,

please review this fix that moves the nmethod arming after registering the nmethods during full gc to make sure that the remaining ones are armed. That changed after JDK-8360540.

Testing: gha

Thanks,
Thomas

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8365976: G1: Full gc should mark nmethods on stack (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26899/head:pull/26899
$ git checkout pull/26899

Update a local copy of the PR:
$ git checkout pull/26899
$ git pull https://git.openjdk.org/jdk.git pull/26899/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26899

View PR using the GUI difftool:
$ git pr show -t 26899

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26899.diff

Using Webrev

Link to Webrev Comment

@tschatzl
8365976
38adef0 
Hi all,

  please review this fix that moves the nmethod arming after registering the nmethods during full gc to make sure that the remaining ones are armed. That changed after https://bugs.openjdk.org/browse/JDK-8360540.

Testing: gha

Thanks,
  Thomas
@bridgekeeper
Copy link

bridgekeeper bot commented Aug 22, 2025

👋 Welcome back tschatzl! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 22, 2025 •
edited
Loading

@tschatzl This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8365976: G1: Full gc should mark nmethods on stack

Reviewed-by: ayang, iwalulya

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title 8365976 8365976: G1: Full gc should mark nmethods on stack Aug 22, 2025
@openjdk
Copy link

openjdk bot commented Aug 22, 2025

@tschatzl The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added hotspot-gc hotspot-gc-dev@openjdk.org rfr Pull request is ready for review labels Aug 22, 2025
@mlbridge
Copy link

mlbridge bot commented Aug 22, 2025

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 22, 2025
@tschatzl
Copy link
Contributor Author

Thanks @walulyai @albertnetymk for your reviews
/integrate

@openjdk
Copy link

openjdk bot commented Aug 25, 2025

Going to push as commit 57434c7.
Since your change was applied there have been 17 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 25, 2025
@openjdk openjdk bot closed this Aug 25, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 25, 2025
@openjdk
Copy link

openjdk bot commented Aug 25, 2025

@tschatzl Pushed as commit 57434c7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@albertnetymk albertnetymk albertnetymk approved these changes

@walulyai walulyai walulyai approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
hotspot-gc hotspot-gc-dev@openjdk.org integrated Pull request has been integrated
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tschatzl @albertnetymk @walulyai